Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust e2e test run script and fixes #6718

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Adjust e2e test run script and fixes #6718

merged 1 commit into from
Jan 12, 2023

Conversation

ShylajaDevadiga
Copy link
Contributor

Signed-off-by: ShylajaDevadiga [email protected]

Proposed Changes

  • Update run_tests.sh script to include more tests.
  • Adjust script to run the tests locally

Verification

NA as it is part of nightly runs

@ShylajaDevadiga ShylajaDevadiga requested a review from a team as a code owner January 11, 2023 17:43
@cwayne18
Copy link
Member

Will this affect the work @dereknola and @nikolaishields are doing on running these tests as part of PR runs?

@ShylajaDevadiga
Copy link
Contributor Author

Will this affect the work @dereknola and @nikolaishields are doing on running these tests as part of PR runs?

No it will not affect running these as part of PR runs

@ShylajaDevadiga ShylajaDevadiga force-pushed the add_tests_to_run_test_script branch from 884bf2f to cee8d56 Compare January 11, 2023 18:46
@codecov-commenter
Copy link

Codecov Report

Base: 9.66% // Head: 9.66% // No change to project coverage 👍

Coverage data is based on head (884bf2f) compared to base (f0ec6a4).
Patch has no changes to coverable lines.

❗ Current head 884bf2f differs from pull request most recent head cee8d56. Consider uploading reports for the commit cee8d56 to get more accurate results

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #6718   +/-   ##
======================================
  Coverage    9.66%   9.66%           
======================================
  Files         139     139           
  Lines       10225   10225           
======================================
  Hits          988     988           
  Misses       9033    9033           
  Partials      204     204
Flag Coverage Δ
unittests 9.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereknola dereknola merged commit fd8481a into k3s-io:master Jan 12, 2023
@cguertin14 cguertin14 mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknola dereknola dereknola approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShylajaDevadiga @cwayne18 @codecov-commenter @brandond @dereknola